Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(aws-kinesisfirehose): DeliveryStream API and S3 Destination #15505

Conversation

madeline-k
Copy link
Contributor

@madeline-k madeline-k commented Jul 11, 2021

This PR implements the DeliveryStream L2 as described in this RFC: aws/aws-cdk-rfcs#342

As well as the S3 Destination. All features of the S3 Destination are implemented here except for Record Format conversion, which is being tracked in #15501

Remaining work:

  • confirm example alarm in README deploys successfully
  • ensure we have handled the race condition in [aws-kinesis] Read permissions to stream doesn't include kinesis:DescribeStream #10783 (comment)
  • add documentation to detail how Lambda invocation must be less that 5 minutes
  • add connection from Firehose CIDR to Lambda VPC for any lambda-based processors
  • consider adding a new grant method on logs.LogStream instead of granting permissions on the entire log group
  • add node ID to stream ID to ensure that a passed-in log group can support multiple destinations adding log streams
  • validate that buffer size is < 6MB for Lambda processing (request/response payloads must be smaller than this)
  • look into alternatives to failing deployment if region is not in CIDR map

closes #10810, #15499


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@gitpod-io
Copy link

gitpod-io bot commented Jul 11, 2021

@madeline-k madeline-k marked this pull request as draft July 11, 2021 22:27
@mergify mergify bot added the contribution/core This is a PR that came from AWS. label Jul 11, 2021
@madeline-k madeline-k marked this pull request as ready for review July 13, 2021 02:58
@madeline-k madeline-k requested a review from rix0rrr July 13, 2021 02:59
@madeline-k madeline-k requested review from skinny85, a team and otaviomacedo July 13, 2021 02:59
@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildProject89A8053A-LhjRyN9kxr8o
  • Commit ID: bfcddaf
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@madeline-k
Copy link
Contributor Author

Closing this Pull request in favor of multiple smaller ones: #15542

@madeline-k madeline-k closed this Jul 14, 2021
mergify bot pushed a commit that referenced this pull request Jul 23, 2021
#15544)

This PR implements the minimum DeliveryStream API and S3 destination.  

More features for DeliveryStream and the S3 destination will follow in future PRs. This work is being tracked in https://github.com/aws/aws-cdk/milestone/16 

For more context, see: #15505 and the RFC: aws/aws-cdk-rfcs#342 

closes #10810, #15499

----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
TikiTDO pushed a commit to TikiTDO/aws-cdk that referenced this pull request Aug 3, 2021
aws#15544)

This PR implements the minimum DeliveryStream API and S3 destination.  

More features for DeliveryStream and the S3 destination will follow in future PRs. This work is being tracked in https://github.com/aws/aws-cdk/milestone/16 

For more context, see: aws#15505 and the RFC: aws/aws-cdk-rfcs#342 

closes aws#10810, aws#15499

----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
hollanddd pushed a commit to hollanddd/aws-cdk that referenced this pull request Aug 26, 2021
aws#15544)

This PR implements the minimum DeliveryStream API and S3 destination.  

More features for DeliveryStream and the S3 destination will follow in future PRs. This work is being tracked in https://github.com/aws/aws-cdk/milestone/16 

For more context, see: aws#15505 and the RFC: aws/aws-cdk-rfcs#342 

closes aws#10810, aws#15499

----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
eladb pushed a commit to cdklabs/decdk that referenced this pull request Jan 18, 2022
…n (#15544)

This PR implements the minimum DeliveryStream API and S3 destination.  

More features for DeliveryStream and the S3 destination will follow in future PRs. This work is being tracked in https://github.com/aws/aws-cdk/milestone/16 

For more context, see: aws/aws-cdk#15505 and the RFC: aws/aws-cdk-rfcs#342 

closes #10810, #15499

----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
contribution/core This is a PR that came from AWS.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

(kinesisfirehose): L2 for CfnDeliveryStream
3 participants